This repository was archived by the owner on Oct 27, 2026. It is now read-only.
Repository navigation
Add deterministic tests scope with once-per-contract Jev review - #16
Closed
brianorwhatever wants to merge 3 commits into
Closed
brianorwhatever wants to merge 3 commits into
brianorwhatever wants to merge 3 commits into
Conversation
Each criterion names tests and path globs. The gate checks in code that every named test passes on head and not on the merge base, that every changed file is mapped, and that required CI succeeded. Jev reviews the contract once per digest, which binds the named test file blobs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 27, 2026
Closed
A combined question left a trivially correct contract below threshold. Separate single-focus questions approve it at 0.93-1.0 and still reject a weakened test (inadequate, p=1.0) and a broad glob (broad, p=0.94). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each tests question now carries the file's setup code and the named test's block instead of every test file, falling back to the whole file when the block cannot be located. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Closing: REV is being scrapped. The deterministic gate worked, but Jev's contract review could not approve real contracts (p 0.5–0.85) and varied by ±0.05 on identical input. Per owner decision, onionoriginals/sdk#1007 now removes REV from the SDK entirely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
scope: tests, a REV gate that decides each push in code: no API key, no model call, no network.tests(file > suite > name) andpaths(globs; catch-alls rejected).scripts/review-contract.jsasks whether the criteria cover the request and whether each criterion's tests would establish it. It reads the exact test blobs and pinsREV_CONTRACT_PR_<n>only on approval.scripts/junit.js: normalizes Bun and Node JUnit into identical test IDs.scripts/tests-change.js: collects the v2 change manifest from Git objects.Existing
pull-requestandacceptancescopes are unchanged.npm run checkandnpm testpass (87 tests, 5 new).🤖 Generated with Claude Code